summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Vlasenko <vda.linux@googlemail.com>2008-12-13 15:21:07 +0000
committerDenis Vlasenko <vda.linux@googlemail.com>2008-12-13 15:21:07 +0000
commit2401710fc05ec38fa5d0f5a2fa68a1f8c322b883 (patch)
tree2d95a70e56cf32f11d8ec2ed7de0840973832bc8
parentbfe8b2c71f492bb8832228aca7dbabe1b7f382e1 (diff)
features.h: add TODO (changing __OPTIMIZE_SIZE__ is a wrong thing to do)
-rw-r--r--include/features.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/include/features.h b/include/features.h
index 1d92a8213..c943c9e6e 100644
--- a/include/features.h
+++ b/include/features.h
@@ -37,7 +37,13 @@
#include <bits/uClibc_arch_features.h>
/* For uClibc, always optimize for size -- this should disable
- * a lot of expensive inlining... */
+ * a lot of expensive inlining...
+ * TODO: this is wrong! __OPTIMIZE_SIZE__ is an indicator of
+ * gcc -Os compile. We should not mess with compiler inlines.
+ * We should instead disable __USE_EXTERN_INLINES unconditionally,
+ * or maybe actually audit and test uclibc to work correctly
+ * with __USE_EXTERN_INLINES on.
+ */
#define __OPTIMIZE_SIZE__ 1
/* These are defined by the user (or the compiler)