From 2401710fc05ec38fa5d0f5a2fa68a1f8c322b883 Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Sat, 13 Dec 2008 15:21:07 +0000 Subject: features.h: add TODO (changing __OPTIMIZE_SIZE__ is a wrong thing to do) --- include/features.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/features.h b/include/features.h index 1d92a8213..c943c9e6e 100644 --- a/include/features.h +++ b/include/features.h @@ -37,7 +37,13 @@ #include /* For uClibc, always optimize for size -- this should disable - * a lot of expensive inlining... */ + * a lot of expensive inlining... + * TODO: this is wrong! __OPTIMIZE_SIZE__ is an indicator of + * gcc -Os compile. We should not mess with compiler inlines. + * We should instead disable __USE_EXTERN_INLINES unconditionally, + * or maybe actually audit and test uclibc to work correctly + * with __USE_EXTERN_INLINES on. + */ #define __OPTIMIZE_SIZE__ 1 /* These are defined by the user (or the compiler) -- cgit v1.2.3