summaryrefslogtreecommitdiff
path: root/libc/misc/utmp/utent.c
AgeCommit message (Collapse)Author
2009-09-05utent.c: fix a few bugs, and shrink a bitDenys Vlasenko
bug #1: static_fd = -1; close(static_fd); DOH! bug #2: if (utmp_fd == -1) { __setutent(); } if (utmp_fd == -1) { return NULL; } if utmp_fd == -1, we call _setutent(). if __setutent() opens a fd, utmp_fd (a parameter) wouldn't change, the second check is bogus. We need to use static_fd instead in second check. Which makes clear that having utmp_fd parameter is wrong. See the patch for a complete fix. Shrink comes from simplifying fcntl(static_fd, F_SETFD, FD_CLOEXEC): text data bss dec hex filename - 661 8 384 1053 41d libc/misc/utmp/utent.o + 604 8 384 996 3e4 libc/misc/utmp/utent.o Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2008-11-20Last portion of libc_hidden_proto removal.Denis Vlasenko
Appears to build fine (several .configs tried)
2008-11-20next portion of libc_hidden_proto removalDenis Vlasenko
2008-11-18libc_hidden_proto removal, just a few functionsDenis Vlasenko
2008-06-12Revert revision 19345 plus libc_hidden_proto for __uc_malloc.Bernd Schmidt
2008-05-19Moving libc_hidden_proto's into #ifdef UCLIBC_INTERNAL blockDenis Vlasenko
in string.h and strings.h. This caught unguarded string ops in libc/inet/ethers.c __ether_line_w() function. I will wait for fallout reports for a week or so, then continue converting more libc_hidden_proto's.
2008-02-12add hidden_proto's for __uc_mallocDenis Vlasenko
(patch by Bernd Schmidt <bernds_cb1 at t-online.de>)
2007-07-30make utent.c, getpass.c use __uc_mallocDenis Vlasenko
2006-12-07Major cleanup of internal mutex locking. Be more consistant in how we doEric Andersen
things, and avoid potential deadlocks caused when a thread holding a uClibc internal lock get canceled and terminates without releasing the lock. This change also provides a single place, bits/uClibc_mutex.h, for thread libraries to modify to change all instances of internal locking.
2006-03-22some more fixes from rholzmann in Bug 716 ... make sure the code actually ↵Mike Frysinger
functions, then we worry about shrinking it ...
2006-02-15make sure we reset static_fd after it's closed in utmpname()Mike Frysinger
2006-02-15fix fcntl() call so that it actually forces file to be closed on exec()Mike Frysinger
2006-02-11rholzmann writes in Bug 716:Mike Frysinger
utent.c has a few problems with mutex locking when used in a binary that was linked with pthreads. The are a few deadlock conditions where functions may be called which lock the utmplock but never release it and where a function that hold the lock calls other functions which try to relock the same lock. For example, notice in the __getutent function the error condition does not unlock the semaphore. The problem is not visible when pthreads isn't used since the lock/unlock functions are NOOP functions.
2006-01-15make gcc4 happy w/ hidden_def/proto, correct some typosPeter S. Mazinger
2006-01-14hidden_def/hidden_proto: convert all users (I hope) termios split, add some ↵Peter S. Mazinger
missing headers, other jump relocs removed
2005-12-13Convert all users of earlier hiddensPeter S. Mazinger
2005-12-07Hide morePeter S. Mazinger
2005-12-06macro out the thread funcs in libc if threading is disabledMike Frysinger
2005-12-01Hide mostly used functionsPeter S. Mazinger
2005-11-29Correct typoPeter S. Mazinger
2005-11-29Hiding againPeter S. Mazinger
2003-12-27Fix a long-standing bug with pthreads. A couple of linuxthreads filesManuel Novoa III
were including libc-lock.h which had a bunch of weak pragmas. Also, uClibc supplied a number of no-op weak thread functions even though many weren't needed. This combined result was that sometimes the functional versions of thread functions in pthread would not override the weaks in libc. While fixing this, I also prepended double-underscore to all necessary weak thread funcs in uClibc, and removed all unused weaks. I did a test build, but haven't tested this since these changes are a backport from my working tree. I did test the changes there and no longer need to explicitly add -lpthread in the perl build for perl to pass its thread self tests.
2002-08-07Remove some noiseEric Andersen
2002-07-16Do not assume NULL termination on the ut_id field. ThanksEric Andersen
to mac12@po.cwru.edu for spotting this one.
2002-06-17Some cleanups so utmp/wtmp behaves. Fix potential use ofEric Andersen
uninitialized memory. Prepare to reentrantify the utmp stuff. -Erik
2002-04-03Richard June <rjune@bravegnuworld.com> noticed that pututlineEric Andersen
was only writing the first sizeof-a-pointer bytes to the utmp file. oops. -Erik
2002-04-03Richard June <rjune@bravegnuworld.com> noticed that setutentEric Andersen
was only opening utmp readonly. Oops.
2002-03-15Add missing updwtmp() and fix broken makefileEric Andersen
2002-01-17Don't print an error if the utmp file doesn't exist, getutent will returnDavid McCullough
NULL as expected.
2001-09-27Update to accomodate the header file changesEric Andersen
2000-12-23Move stuff out if pwd_gep that doesn't belong there (getpass, utmp stuff)Eric Andersen