diff options
author | Eric Andersen <andersen@codepoet.org> | 2007-02-02 00:30:30 +0000 |
---|---|---|
committer | Eric Andersen <andersen@codepoet.org> | 2007-02-02 00:30:30 +0000 |
commit | b38dc057f7bff85d052b5560aecd17ce78efabc0 (patch) | |
tree | c11b8ab3fa5c840942f6bf8607a559c002f8b0a8 /libc/stdlib/gcvt.c | |
parent | 9af4b40d3886077df93b02458026f6a9766ac6c9 (diff) |
Ronald Maeder writes:
Hi Erik,
Thanks for all your great work. I found a set of bugs in
resolv.c . Basically, there is code that looks like:
BIGLOCK;
__nameserversXX=__nameservers;
__nameserverXX=__nameserver;
BIGUNLOCK;
i = __dns_lookup(dname, type, __nameserversXX, __nameserverXX, &packet, &a);
which is a problem because the declarations are
int __nameservers;
char * __nameserver[MAX_SERVERS];
int __searchdomains;
char * __searchdomain[MAX_SEARCH];
so you can see that __nameserver is a pointer. Copying the
pointer to __nameserverXX doesn't protect the global variable
space. I have attached a patch and the new file. I hope you
will incorporate these bug fixes. I spent quite a bit of time
tracking them down.
Many thanks,
Ron
Diffstat (limited to 'libc/stdlib/gcvt.c')
0 files changed, 0 insertions, 0 deletions