diff options
| author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-04-12 01:34:04 +0000 |
|---|---|---|
| committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-04-12 01:34:04 +0000 |
| commit | 07bbf922670cce83c0b54f28ad43473d044cae5e (patch) | |
| tree | bc0febf583571380d2bf78f8759bc0a770031fc6 /libc/inet/addr.c | |
| parent | a8a63535295e35307f63adc1d665f13016f65110 (diff) | |
Functions should be either exported in public .h files
and marked with libc_hidden_proto/def(),
or not be exported in .h files
and be hidden (or even static if possible).
We have five functions which violate this. Fixing:
netdb.h: export ruserpass()
rpc/rpc.h: export xdr_accepted_reply() and xdr_rejected_reply()
make inet_ntoa_r static function (it is not exported in any .h file)
make _time_tzset hidden function (it is not exported in any .h file)
Diffstat (limited to 'libc/inet/addr.c')
| -rw-r--r-- | libc/inet/addr.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/libc/inet/addr.c b/libc/inet/addr.c index 94fa3aab7..cbe3d6893 100644 --- a/libc/inet/addr.c +++ b/libc/inet/addr.c @@ -122,9 +122,7 @@ libc_hidden_def(inet_addr) #define INET_NTOA_MAX_LEN 16 /* max 12 digits + 3 '.'s + 1 nul */ -extern char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]); -libc_hidden_proto(inet_ntoa_r) -char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) +static char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) { in_addr_t addr = ntohl(in.s_addr); int i; @@ -143,7 +141,6 @@ char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) return p+1; } -libc_hidden_def(inet_ntoa_r) libc_hidden_proto(inet_ntoa) char *inet_ntoa(struct in_addr in) |