diff options
| author | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2010-06-10 22:20:17 +0200 |
|---|---|---|
| committer | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2010-06-10 22:23:54 +0200 |
| commit | 0f0cf7ec49719ab3c357813689bf1095234d6533 (patch) | |
| tree | a696368bfa111461e2501fceb0bb43dea5170aac | |
| parent | 0671149ee68ee76d357c6dade14249fc9858d934 (diff) | |
lgamma: fix sign handling
add testcase from
http://sourceware.org/bugzilla/show_bug.cgi?id=4407
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
| -rw-r--r-- | libm/e_lgamma_r.c | 6 | ||||
| -rw-r--r-- | test/.gitignore | 1 | ||||
| -rw-r--r-- | test/math/Makefile.in | 3 | ||||
| -rw-r--r-- | test/math/signgam.c | 18 |
4 files changed, 26 insertions, 2 deletions
diff --git a/libm/e_lgamma_r.c b/libm/e_lgamma_r.c index 2b1fde78c..23c96d808 100644 --- a/libm/e_lgamma_r.c +++ b/libm/e_lgamma_r.c @@ -208,7 +208,11 @@ double attribute_hidden __ieee754_lgamma_r(double x, int *signgamp) *signgamp = 1; ix = hx&0x7fffffff; if(ix>=0x7ff00000) return x*x; - if((ix|lx)==0) return one/zero; + if((ix|lx)==0) { + if (__signbitl(x)) + *signgamp = -1; + return one/zero; + } if(ix<0x3b900000) { /* |x|<2**-70, return -log(|x|) */ if(hx<0) { *signgamp = -1; diff --git a/test/.gitignore b/test/.gitignore index 464130d57..2070168b9 100644 --- a/test/.gitignore +++ b/test/.gitignore @@ -119,6 +119,7 @@ math/compile_test math/libm-test-ulps.h math/libm-test.c math/rint +math/signgam math/test-double math/test-ildoubl math/test-ldouble diff --git a/test/math/Makefile.in b/test/math/Makefile.in index b160c875d..8a46e77db 100644 --- a/test/math/Makefile.in +++ b/test/math/Makefile.in @@ -1,7 +1,7 @@ # uClibc math tests # Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball. -TESTS := basic-test rint tst-definitions test-fpucw test-float test-ifloat test-double test-idouble +TESTS := basic-test rint signgam tst-definitions test-fpucw test-float test-ifloat test-double test-idouble ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),y) TESTS += test-ldouble test-ildoubl compile_test else @@ -9,6 +9,7 @@ CFLAGS_basic-test := -DNO_LONG_DOUBLE endif DODIFF_rint := 1 +DODIFF_signgam := 1 # NOTE: For basic-test we must disable the floating point optimization. # Only for sh architecture because in the other architecture are disabled. diff --git a/test/math/signgam.c b/test/math/signgam.c new file mode 100644 index 000000000..c60375aec --- /dev/null +++ b/test/math/signgam.c @@ -0,0 +1,18 @@ +#define _XOPEN_SOURCE 600 +#include <math.h> +#include <stdio.h> + +double zero = 0.0; +double mzero; + +int +main (void) +{ + double d; + mzero = copysign (zero, -1.0); + d = lgamma (zero); + printf ("%g %d\n", d, signgam); + d = lgamma (mzero); + printf ("%g %d\n", d, signgam); + return 0; +} |