From c243c796177ca2cd595f4ab394d4f4911812027d Mon Sep 17 00:00:00 2001 From: Eric Andersen Date: Tue, 11 Jan 2005 11:31:55 +0000 Subject: Jean writes: Hello, under some circumstances the following small example prints lots of garbage onto the console and into the syslog: #include int main () { openlog("foo", LOG_CONS|LOG_NDELAY|LOG_PID|LOG_PERROR, LOG_DAEMON); syslog (LOG_WARNING, "mlock: %m"); return 1; } The reason is, that sprintf returns with -1 and vsyslog dumps the complete buffer onto stderr and the syslogd socket. The following patch would fix the problem: --- libc/misc/syslog/syslog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libc/misc/syslog/syslog.c b/libc/misc/syslog/syslog.c index 250cb6ddc..e39e63a05 100644 --- a/libc/misc/syslog/syslog.c +++ b/libc/misc/syslog/syslog.c @@ -206,7 +206,15 @@ vsyslog( int pri, const char *fmt, va_list ap ) memmove(head_end + sizeof(truncate_msg), head_end, end - head_end - sizeof(truncate_msg)); memcpy(head_end, truncate_msg, sizeof(truncate_msg)); - p = end - 1; + if (p < head_end) { + while (p < end && *p) { + p++; + } + } + else { + p = end - 1; + } + } last_chr = p; -- cgit v1.2.3